Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Update the code with latest KEP #38

Merged
merged 6 commits into from
Aug 4, 2022
Merged

Update the code with latest KEP #38

merged 6 commits into from
Aug 4, 2022

Conversation

mukhoakash
Copy link
Contributor

Updated the go version and go.mod and go.sum files,
Updated the spec file,
Updated the auto generated file,
Fixed the make routines with correct updated behavior of the dependent packages.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 14, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @mukhoakash!

It looks like this is your first PR to kubernetes-sigs/container-object-storage-interface-spec 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/container-object-storage-interface-spec has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 14, 2022
@wlan0
Copy link
Contributor

wlan0 commented Jul 21, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2022
@wlan0 wlan0 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2022
@wlan0
Copy link
Contributor

wlan0 commented Jul 21, 2022

/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2022
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mukhoakash mukhoakash changed the title [WIP] Update the code with latest KEP Update the code with latest KEP Jul 26, 2022
@mukhoakash
Copy link
Contributor Author

/assign @jsafrane

@wlan0 wlan0 added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 4, 2022
@wlan0 wlan0 merged commit 3154aa8 into kubernetes-retired:master Aug 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mukhoakash, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mukhoakash mukhoakash mentioned this pull request Aug 11, 2022
Closed
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@wlan0 wlan0

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mukhoakash @k8s-ci-robot @wlan0 @jsafrane